Updated function definition causing 500 error #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had an issue with one of my projects where this file was causing [laravel-opcache](https://github.com/appstract/laravel-opcache) to throw a 500 error. > syntax error, unexpected 'public' (T_PUBLIC), expecting variable (T_VARIABLE) {"url":"/opcache-api/compile","exception":"[object] (Symfony\Component\Debug\Exception\FatalThrowableError(code: 0): syntax error, unexpected 'public' (T_PUBLIC), expecting variable (T_VARIABLE) at vendor/symfony/service-contracts/Attribute/SubscribedService.php:30) After removing public from the function definition, everything worked as expected.
|
Thanks for your pull request! We love contributions. However, this repository is what we call a "subtree split": a read-only copy of one directory of the main Symfony contracts repository. It is used by Composer to allow developers to depend on specific Symfony contracts. If you want to contribute, you should instead open a pull request on the main repository: https://github.com/symfony/contracts Thank you for your contribution! PS: if you haven't already, please add tests, and beware that bug fixes should be submitted on the lowest maintained branch where they apply; only features should be submitted against the main branch. |
N3rdP1um23
changed the title
|
Closing PR as the issue thread has been closed - symfony/symfony#44924 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue with one of my projects where this file was causing laravel-opcache to throw a 500 error.
After removing public from the function definition, everything worked as expected.
This is to correct the following issue - symfony/symfony#44924