Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/security-core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: aeb3330
Choose a base ref
...
head repository: symfony/security-core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a801d52
Choose a head ref
  • 3 commits
  • 10 files changed
  • 2 contributors

Commits on Mar 6, 2023

  1. [Tests] Replace setMethods() by onlyMethods() and addMethods()

    @alexandre-daubois
    alexandre-daubois committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    2363f8e View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. [Tests] Remove occurrences of withConsecutive()

    @alexandre-daubois @nicolas-grekas
    alexandre-daubois authored and nicolas-grekas committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    e41d909 View commit details
    Browse the repository at this point in the history

  2. minor #49621 [Tests] Remove occurrences of withConsecutive() (alexa… 

    …ndre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Tests] Remove occurrences of `withConsecutive()`

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

`withConsecutive()` has been deprecated in PHPUnit 9.6 and removed in PHP 10 (sebastianbergmann/phpunit#4564). This PR aims at starting the work to remove these occurrences. There is unfortunately no given migration path, and this requires manual work.

I'll create a meta issue referencing remaining occurrences if this one's merged, to keep track. Some seems pretty hard to remove.

cc `@OskarStark` this might interest you, as we worked a lot on tests lately 😄

Commits
-------

2047763649 [Tests] Remove occurrences of `withConsecutive()`
    @nicolas-grekas
    nicolas-grekas committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    a801d52 View commit details
    Browse the repository at this point in the history
Loading