[Security] Renamed in memory provider #741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Feb 13, 2020
yceruto
approved these changes
Feb 13, 2020
Pierstoval
approved these changes
Feb 13, 2020
HeahDude
force-pushed
the
fix-security-memory-provider
branch
from
18e3425 to
844198d
Compare
ghost
suggested changes
Feb 13, 2020
nicolas-grekas
approved these changes
Feb 13, 2020
ghost
pushed a commit
that referenced
this pull request
Feb 13, 2020
ghost
merged commit
HeahDude
added a commit
to symfony/symfony-docs
that referenced
this pull request
Feb 16, 2020
…er for all user types (HeahDude) This PR was merged into the 3.4 branch. Discussion ---------- [Security] renamed memory provider and a tip about encoder for all user types A follow up of symfony/recipes#741. Commits ------- bdccc33 [Security] renamed memory provider
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the default memory provider has always been confusing to me, and keep being confusing for my trainees, training after training.
Here an attempt to clarify that this is a name and not the type.
Also, having multiple providers without making explicite the one used by the firewall throws from Symfony 4, so I propose to reflect that in the recipe (maybe we should do so in the 3.3 recipe too).
If you agree I'll update the docs accordingly. Thanks!