Skip to content

[RFC] Added a recipe for the Workflow component #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Nov 14, 2017
Merged

[RFC] Added a recipe for the Workflow component #256

1 commit merged into from
Nov 14, 2017

Conversation

javiereguiluz
Copy link
Member

@javiereguiluz javiereguiluz commented Nov 14, 2017 •
edited
Loading

Q A
License MIT

Just a proposal. Reasons:

  • it would allow to better separate the app config;
  • it improves discoverability (you no longer would have to guess that workflows were configured in config/packages/framework.yaml);
  • it aligns with Flex philosophy (small and stand alone config files instead of just 1 big config file).

ghost
ghost approved these changes Nov 14, 2017
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Nov 14, 2017
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@javiereguiluz javiereguiluz mentioned this pull request Nov 14, 2017
Merged
@ghost ghost merged commit 6e72ce6 into symfony:master Nov 14, 2017
ghost pushed a commit that referenced this pull request Nov 14, 2017
Merge pull request #256
8443def
weaverryan added a commit to symfony/symfony-docs that referenced this pull request Nov 16, 2017
@weaverryan
minor #8654 Updated the Workflow articles to Symfony 4 (javiereguiluz…
7699ca2 
…, weaverryan)

This PR was merged into the master branch.

Discussion
----------

Updated the Workflow articles to Symfony 4

The new file config paths are pending of this: symfony/recipes#256

Commits
-------

70dda7c adding use
f9bb412 minor tweaks
8c540ce Removed an unneeded comment (Flex now includes Console by default)
5088d0e Lots of fixes
0261149 Fixed a typo
9690dfd Updated the Workflow articles to Symfony 4
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javiereguiluz @fabpot @xabbuh