Skip to content

[Notifier] Add ClickSend bridge #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2023
Merged

[Notifier] Add ClickSend bridge #1159

merged 1 commit into from
May 31, 2023

Conversation

gnito-org
Copy link
Contributor

Q A
License MIT
Doc issue/PR symfony/symfony-docs#17509

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) December 5, 2022 18:48
@github-actions
Copy link

github-actions bot commented Dec 5, 2022 •
edited
Loading

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1159/index.json
# On Windows
SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1159/index.json

  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
composer req 'symfony/click-send-notifier:^6.3'

  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
unset SYMFONY_ENDPOINT
# On Windows
SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@gnito-org gnito-org mentioned this pull request Dec 5, 2022
Merged
nicolas-grekas added a commit to symfony/symfony that referenced this pull request May 12, 2023
@nicolas-grekas
feature #48494 [Notifier] Add ClickSend notifier bridge (gnito-org)
6ec3943 
This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[Notifier] Add ClickSend notifier bridge

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       |
| License       | MIT
| Doc PR        | symfony/symfony-docs#17509
| Recipe         | symfony/recipes#1159
<!--
Replace this notice by a short README for your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the latest branch.
 - For new features, provide some code snippets to help understand usage.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Commits
-------

a3ca045 [Notifier] Add ClickSend notifier bridge
@gnito-org gnito-org closed this May 31, 2023
auto-merge was automatically disabled May 31, 2023 12:22

Pull request was closed

@fabpot fabpot reopened this May 31, 2023
@fabpot
Copy link
Member

fabpot commented May 31, 2023

Why have you closed, this PR is still relevant and should be merged.

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 31, 2023 13:18
@fabpot fabpot disabled auto-merge May 31, 2023 13:21
@fabpot fabpot merged commit 2629c8e into symfony:main May 31, 2023
@gnito-org gnito-org deleted the click-send-notifier branch May 31, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Waiting Code Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gnito-org @fabpot @OskarStark