Skip to content

[Notifier] Add Plivo bridge #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2022
Merged

[Notifier] Add Plivo bridge #1154

merged 2 commits into from
Dec 2, 2022

Conversation

gnito-org
Copy link
Contributor

Q A
License MIT
Doc issue/PR symfony/symfony-docs#17484

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 29, 2022 17:20
@github-actions
Copy link

github-actions bot commented Nov 29, 2022 •
edited
Loading

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1154/index.json
# On Windows
SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1154/index.json

  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
composer req 'symfony/plivo-notifier:^6.3'

  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
unset SYMFONY_ENDPOINT
# On Windows
SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@gnito-org gnito-org mentioned this pull request Nov 29, 2022
Merged
@gnito-org
Revert "Auxiliary commit to revert individual files from 5da74a6"
7367574 
This reverts commit c08a7050f56caf95143c4037bb7614631fb9a4c3.
auto-merge was automatically disabled November 29, 2022 23:40

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 29, 2022 23:40
fabpot added a commit to symfony/symfony that referenced this pull request Dec 2, 2022
@fabpot
feature #48394 [Notifier] Add Plivo bridge (gnito-org)
3751b28 
This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[Notifier] Add Plivo bridge

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | symfony/symfony-docs#17484
| Recipe         | symfony/recipes#1154

This PR add the [Plivo](https://www.plivo.com) Notifier bridge (SMS).
<!--
Replace this notice by a short README for your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the latest branch.
 - For new features, provide some code snippets to help understand usage.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Commits
-------

72e8416 [Notifier] Add Plivo bridge
@fabpot fabpot disabled auto-merge December 2, 2022 16:33
@fabpot fabpot merged commit ae6742e into symfony:main Dec 2, 2022
@gnito-org gnito-org deleted the plivo-notifier branch December 3, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Waiting Code Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gnito-org @fabpot @OskarStark