Skip to content

Move recipes from metas to packs #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Move recipes from metas to packs #1093

merged 1 commit into from
Jun 3, 2022

Conversation

nicolas-grekas
Copy link
Member

Q A
License MIT
Doc issue/PR -

Since symfony/flex#923, recipes can be bound to packs and still be managed by recipes:update.
Aka packs don't need a sibling *-meta repo anymore.

@github-actions github-actions bot enabled auto-merge (squash) June 3, 2022 08:23
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1093/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1093/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'api-platform/admin-pack:^1.0' 'symfony/psr7-pack:^1.0' 'symfony/webapp-pack:^1.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

nicolas-grekas added a commit to symfony/psr7-pack that referenced this pull request Jun 3, 2022
nicolas-grekas added a commit to symfony/webapp-pack that referenced this pull request Jun 3, 2022
nicolas-grekas added a commit to nicolas-grekas/admin-pack that referenced this pull request Jun 3, 2022
nicolas-grekas added a commit to symfony/webapp-pack that referenced this pull request Jun 3, 2022
nicolas-grekas added a commit to symfony/psr7-pack that referenced this pull request Jun 3, 2022
dunglas pushed a commit to api-platform/admin-pack that referenced this pull request Jun 3, 2022
@github-actions github-actions bot merged commit ff88520 into main Jun 3, 2022
@github-actions github-actions bot deleted the no-meta branch June 3, 2022 13:32
@kbond
Copy link
Member

kbond commented Jun 3, 2022

We'll need new flex releases.

@stof
Copy link
Member

stof commented Jun 3, 2022

indeed, this should not have been done before releasing the Flex version supporting the pre-requisite, because recipe changes go live on merge, while Flex changes don't propagate in the ecosystem until the release is done (and even then, it is safer to give a bit of time)

@nicolas-grekas
Copy link
Member Author

All tags pushed. This should all work nicely now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants