-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[symfony/mailer] use null://null
for MAILER_DSN
#1071
Conversation
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. |
We could simply update the |
I don't believe the recipe can update |
Yeah it looks like it can: https://github.com/symfony/recipes/blob/master/phpunit/phpunit/4.7/manifest.json#L3
Yes, and in the But that was just a suggestion, I don't know what solution prefers the core team 👀 |
I meant add a single line to the
Both achieve the same thing, doesn't matter to me. Adding the the phpunit/phpunit-bridge recipes seems simpler. |
null://null
test dsnnull://null
for MAILER_DSN
I modified this PR to just always use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense.
This makes it easier to run tests that send emails "out of the box".