Skip to content

[symfony/security-bundle] use lowest possible p/w hash "work factor" in test env #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2021
Merged

[symfony/security-bundle] use lowest possible p/w hash "work factor" in test env #1026

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
691cd98
use lowest possible p/w hash "work factor" in test env
kbond Nov 22, 2021
6c66020
Update symfony/security-bundle/5.3/config/packages/security.yaml
kbond Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions symfony/security-bundle/5.3/config/packages/security.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,16 @@ security:
access_control:
# - { path: ^/admin, roles: ROLE_ADMIN }
# - { path: ^/profile, roles: ROLE_USER }

when@test:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use when@test here? It's probably fine... but there's no guarantee the user has FWBundle 5.3 :/

Copy link
Member

@stof stof Nov 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not related to FrameworkBundle. That's related to the version of the DI and HttpKernel components. And for those, we have that guarantee

security:
password_hashers:
# By default, password hashers are resource intensive and take time. This is
# important to generate secure password hashes. In tests however, secure hashes
# are not important, waste resources and increase test times. The following
# reduces the work factor to the lowest possible values.
Symfony\Component\Security\Core\User\PasswordAuthenticatedUserInterface:
algorithm: auto
cost: 4 # Lowest possible value for bcrypt
time_cost: 3 # Lowest possible value for argon
memory_cost: 10 # Lowest possible value for argon