- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 150
feature [8.4][bcmath] implement bcround, bcceil and bcfloor #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            Dean151
  wants to merge
  1
  commit into
  symfony:1.x
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
Dean151:feat/bcceil-bcfloor-bcround
  
      
      
   
  
    
  
  
  
 
  
      
    base: 1.x
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from all commits
      Commits
    
    
  File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| <?php | ||
|  | ||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|  | ||
| /* | ||
| if (\PHP_VERSION_ID >= 80100 && \PHP_VERSION_ID < 80400) { | ||
| enum RoundingMode { | ||
| case HalfAwayFromZero; // Round to the nearest integer. If the decimal part is 5, round to the integer with the larger absolute value. | ||
| case HalfTowardsZero; // Round to the nearest integer. If the decimal part is 5, round to the integer with the smaller absolute value. | ||
| case HalfEven; // Round to the nearest integer. If the decimal part is 5, round to the even integer. | ||
| case HalfOdd; // Round to the nearest integer. If the decimal part is 5, round to the odd integer. | ||
| case TowardsZero; // Round to the nearest integer with a smaller or equal absolute value. | ||
| case AwayFromZero; // Round to the nearest integer with a greater or equal absolute value. | ||
| case NegativeInfinity; // Round to the largest integer that is smaller or equal. | ||
| case PositiveInfinity; // Round to the smallest integer that is greater or equal. | ||
| } | ||
| } | ||
| if (\PHP_VERSION_ID < 80100) { | ||
| */ | ||
| if (\PHP_VERSION_ID < 80400) { | ||
| // @author Thomas Durand <github@thomasdurand.fr> | ||
| final class RoundingMode { | ||
| const HalfAwayFromZero = 0; // Round to the nearest integer. If the decimal part is 5, round to the integer with the larger absolute value. | ||
| const HalfTowardsZero = 1; // Round to the nearest integer. If the decimal part is 5, round to the integer with the smaller absolute value. | ||
| const HalfEven = 2; // Round to the nearest integer. If the decimal part is 5, round to the even integer. | ||
| const HalfOdd = 3; // Round to the nearest integer. If the decimal part is 5, round to the odd integer. | ||
| const TowardsZero = 4; // Round to the nearest integer with a smaller or equal absolute value. | ||
| const AwayFromZero = 5; // Round to the nearest integer with a greater or equal absolute value. | ||
| const NegativeInfinity = 6; // Round to the largest integer that is smaller or equal. | ||
| const PositiveInfinity = 7; // Round to the smallest integer that is greater or equal. | ||
|  | ||
| private function __construct() {} | ||
|  | ||
| public static function cases(): array | ||
| { | ||
| return [ | ||
| self::HalfAwayFromZero, | ||
| self::HalfTowardsZero, | ||
| self::HalfEven, | ||
| self::HalfOdd, | ||
| self::TowardsZero, | ||
| self::AwayFromZero, | ||
| self::NegativeInfinity, | ||
| self::PositiveInfinity, | ||
| ]; | ||
| } | ||
| } | ||
| } | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when PHP >= 8.1 is used, we should use a real enum
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolas-grekas When I try to introduce an enum, even behind an if PHP_VERSION_ID, older PHP version are complaining pretty badly on the syntax.
See this CI run
An idea?