Add PHP 7.4 to Travis test matrix #359
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Sep 18, 2020
Merged
Author
|
Closed in favor of #360 |
lyrixx
added a commit
that referenced
this pull request
Oct 2, 2020
This PR was merged into the 3.x-dev branch. Discussion ---------- Fix tests for php7 Combines previous PRs #358 and #359 together with fixes for failing tests on Travis. * Updates travis test matrix: * Adds PHP 7.4 to test matrix * Expands test matrix for PHP 7.2+ to check against both monolog 1 & 2 * Fixes PHPUnit deprecations: * Fixes invalid method signature for `setUp()` * Replaces deprecated assertions (assertContains, assertNotContains) * Replaces deprecated expectedExceptions annotations * Fixes missing service definitions in container configurations Closes #351 as well Commits ------- e71163a Fix tests failing in PHP 7.1+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.