Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if json_array type exists before unsetting it #991

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Check if json_array type exists before unsetting it #991

merged 2 commits into from
Oct 13, 2021

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Oct 11, 2021

Fixes #987

Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Tests are failing hard - but it's related to symfony/flex#820

@HypeMC
Copy link
Contributor Author

HypeMC commented Oct 13, 2021

@weaverryan I've fixed the package names, should be ok now.

@weaverryan
Copy link
Member

Thanks for the fix and the extra fix with the orm-pack :). Cheers @HypeMC!

@cadot-info
Copy link

i share a patch for similar problem :

--- /dev/null
+++ ../PropertyInfo/DoctrineExtractor.php
@@ -280,7 +280,6 @@
 
             case Types::ARRAY:
             case Types::SIMPLE_ARRAY:
-            case Types::JSON_ARRAY:
                 return Type::BUILTIN_TYPE_ARRAY;
         }

apply by composer

 "extra": {
     ...
        "patches": {
            "symfony/doctrine-bridge": [
                "the file.patch"
            ]
        }

...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maker bundle 1.34 incompatible with latest Doctrine DBAL (tested 3.1.3)
3 participants