Make Crud - Change field name appearance #544
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbaarsma
approved these changes
Apr 10, 2020
| @@ -19,13 +24,13 @@ | |||
| <td>{{ <?= $helper->getEntityFieldPrintCode($entity_twig_var_singular, $field) ?> }}</td> | |||
| <?php endforeach; ?> | |||
| <td> | |||
| <a href="{{ path('<?= $route_name ?>_show', {'<?= $entity_identifier ?>': <?= $entity_twig_var_singular ?>.<?= $entity_identifier ?>}) }}">show</a> | |||
| <a href="{{ path('<?= $route_name ?>_edit', {'<?= $entity_identifier ?>': <?= $entity_twig_var_singular ?>.<?= $entity_identifier ?>}) }}">edit</a> | |||
| <a href="{{ path('<?= $route_name ?>_show', {'<?= $entity_identifier ?>': <?= $entity_twig_var_singular ?>.<?= $entity_identifier ?>}) }}">Show</a> | |||
There was a problem hiding this comment.
I guess it's debatable whether or not these should be capitalized. Personally I see as headings and think they should have a capital letter, but as values (similar to bullet list) and don't give them a capital letter, unless it's a name or some such.
A quick search on Google reveals there's no universal standard for table cells. In my experience many values in cells are database values that could be wrongly interpreted when given a capital letter, therefore I suggest to not give them a capital letter.
There was a problem hiding this comment.
@weaverryan wdyt ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #543
I Adapted
asHumanWordsmethod to be more clever