Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make:twig-component] Improve make:twig-component by reading the configuration file #1571

Merged
merged 14 commits into from
Jun 18, 2024
Merged

[make:twig-component] Improve make:twig-component by reading the configuration file #1571

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
69b4044
Improve the make:twig_component command to read the first entry in th…
shadowc Jun 12, 2024
a6c3ad5
Add missing argument
shadowc Jun 12, 2024
8ed257d
Remove \App from the namespace
shadowc Jun 12, 2024
f0e79a1
Code fixes
shadowc Jun 14, 2024
ad69c09
remove unused import
shadowc Jun 14, 2024
44e8a97
php-cs-fixer fixes
shadowc Jun 14, 2024
e8e1f16
Add checks for yaml parsing validation
shadowc Jun 15, 2024
98d77fb
Fix code style
shadowc Jun 15, 2024
e018df8
Add test
shadowc Jun 15, 2024
4053f45
Update tests/Maker/MakeTwigComponentTest.php
shadowc Jun 17, 2024
4c2e861
call copy before running maker
jrushlow Jun 17, 2024
c273122
refactor interact method try..catch
shadowc Jun 17, 2024
815075a
Remove unused import
shadowc Jun 17, 2024
365e7b4
Add throw statements on errors
shadowc Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix code style
  • Loading branch information
@shadowc
shadowc committed Jun 15, 2024
commit 98d77fbdb24f44ee9db94876628c1c0d7ba630a5
2 changes: 1 addition & 1 deletion src/Maker/MakeTwigComponent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public function interact(InputInterface $input, ConsoleStyle $io, Command $comma
return;
}

if (!array_key_exists('twig_component', $value) || !array_key_exists('defaults', $value['twig_component'])) {
if (!\array_key_exists('twig_component', $value) || !\array_key_exists('defaults', $value['twig_component'])) {
return;
}

Expand Down
Loading