Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[make:crud] Remove extra dot #1433

Merged
merged 1 commit into from
Feb 3, 2024
Merged

[make:crud] Remove extra dot #1433

merged 1 commit into from
Feb 3, 2024

Conversation

annechko
Copy link
Contributor

@annechko annechko commented Feb 3, 2024

Hi! Noticed an extra dot after a question mark in tests question

Do you want to generate tests for the controller?. [Experimental] (yes/no) [no]:

@jrushlow jrushlow added Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer labels Feb 3, 2024
jrushlow
jrushlow approved these changes Feb 3, 2024
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you @annechko

@jrushlow jrushlow merged commit 7afba4f into symfony:main Feb 3, 2024
4 of 6 checks passed
@annechko annechko deleted the patch-1 branch February 4, 2024 07:54
@jrushlow jrushlow mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrushlow jrushlow jrushlow approved these changes

Assignees
No one assigned
Labels
Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annechko @jrushlow