Add collection as reserved keywords #1389
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1380
In the
generate method
we call theGenerator class
and the methodcreateClassNameDetails
.And in this method we call the static method
validateClassName
of theValidator class
.In it we already have a check about the reserved keywords.
Is this the best solution to avoid these dangerous/ambiguous class names?
Because this method is also called by the other makers.
Or do we need to add an additional verification in the entity maker?