Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create empty-ready construct on command generate #1355

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Create empty-ready construct on command generate #1355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Resources/skeleton/command/Command.tpl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@
)]
class <?= $class_name; ?> extends Command
{
public function __construct()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have this?

Suggested change
public function __construct()
public function __construct(string $name = null)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, we don't need that.

https://symfony.com/doc/current/console.html#getting-services-from-the-service-container

{
parent::__construct();
}

protected function configure(): void
{
$this
Expand Down