Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make:registration-form] render the raw signedUrl in the email template #1217

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Oct 4, 2022

Template:

Twig is escaping the signedUrl provided by VerifyEmailBundle - we shouldn't do this in the template...

Before: (Note the & separator in the query string)

http://localhost/verify/email?expires=1664884822&id=1&signature=TcUbEcrs7QXcxPdU%2Bb6OZVI%2FkcZ4gGq6JTvubDSG04o%3D&token=g%2BOsXoKFi5iT73QjyezR74Rya1Gy8UtryhEMbmK%2FUB4%3D

Now:

http://localhost/verify/email?expires=1664884822&id=1&signature=TcUbEcrs7QXcxPdU%2Bb6OZVI%2FkcZ4gGq6JTvubDSG04o%3D&token=g%2BOsXoKFi5iT73QjyezR74Rya1Gy8UtryhEMbmK%2FUB4%3D

Tests:

Without the context, we now have to grab the uri from the email body

@jrushlow jrushlow added the Minor Minor Enhancement label Oct 4, 2022
@jrushlow jrushlow added Bug Bug Fix and removed Minor Minor Enhancement labels Oct 4, 2022
@jrushlow jrushlow changed the title [make:registration-form] handle 6.2 no context in rendered email [make:registration-form] render the raw signedUrl in the email template Oct 4, 2022
@jrushlow jrushlow merged commit 32b6011 into symfony:main Oct 4, 2022
@jrushlow jrushlow deleted the fix/make-reg-6.2 branch October 4, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants