[tests] bring test suite up to PHP8 standards#1129
Conversation
jrushlow
force-pushed
the
legacy/src-tests
branch
from
4f6a482 to
f7560c6
Compare
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
minor comments, but looks good 👍
|
|
||
| public function setRequiredPhpVersion(int $version): self | ||
| { | ||
| @trigger_deprecation('symfony/maker-bundle', 'v1.44.0', 'setRequiredPhpVersion() is no longer used and will be removed in a future version.'); |
There was a problem hiding this comment.
Are we sure we won't need this again? :)
There was a problem hiding this comment.
Nope. But we are not using it within the code base at the moment. Because the class isn't internal - I figured we'd throw the deprecation. And if/when we need to use this (PHP 9ish) - we can either remove the deprecation or add a replacement internal method that gives us a bit more freedom.
I think we are going with a similar strategy w/ the PHPCompatUtil - we don't have a need for now (probably wont until PHP 9ish). So when we introduced the util in non-internal classes, we added a deprecation that "hey, you need to supply this util.. it'll be mandatory in the next version..." Now that we don't need it in say MakeWhatever::class, I changed the wording on the deprecation "hey, you dont need to supply this..."
That strategy kinda sucks, but I can't think of a better way w/ non internal classes. Any ideas?
weaverryan
force-pushed
the
legacy/src-tests
branch
from
9a62803 to
669c325
Compare
|
Thanks Jesse! |
2 participants
No description provided.