Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typed properties for make:reset-password and make:registration #1028

Merged
merged 3 commits into from
May 3, 2022
Merged

Add typed properties for make:reset-password and make:registration #1028

merged 3 commits into from
May 3, 2022

Conversation

seb-jean
Copy link
Contributor

@seb-jean seb-jean commented Dec 1, 2021

No description provided.

jrushlow
jrushlow requested changes Feb 22, 2022
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because maker-bundle still supports PHP < 7.4, we'll need a conditional for typed properties.

maker-bundle/src/Resources/skeleton/authenticator/Security52LoginFormAuthenticator.tpl.php

Line 25 in bff3fbb

private <?= $use_typed_properties ? 'UrlGeneratorInterface ' : null ?>$urlGenerator;

@jrushlow jrushlow added the Status: Needs Work Additional work is needed label Feb 22, 2022
@jrushlow jrushlow added the Feature New Feature label Mar 3, 2022
@jrushlow jrushlow changed the title Add types Add typed properties for make:reset-password and make:registration May 3, 2022
jrushlow
jrushlow approved these changes May 3, 2022
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @seb-jean!

@jrushlow jrushlow added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Work Additional work is needed labels May 3, 2022
@jrushlow jrushlow merged commit 6036523 into symfony:main May 3, 2022
@jrushlow jrushlow mentioned this pull request May 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrushlow jrushlow jrushlow approved these changes

Assignees
No one assigned
Labels
Feature New Feature Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seb-jean @jrushlow