make:entity wrong setter for non nullable fields

[sbruev]

Hi!
It's a minor syntax mistake, but right now generated setters allow to pass the null value to non nullable fields, if they are ManyToOne relationship.

    /**
     * @ORM\ManyToOne(targetEntity="App\Entity\AnotherEntity")
     * @ORM\JoinColumn(nullable=false)
     */
    private $anotherEntity;

    //...

    public function setAnotherEntity(?AnotherEntity $anotherEntity): self
    {
        $this->anotherEntity = $anotherEntity;

        return $this;
    }

The arg should be AnotherEntity not ?AnotherEntity

Cheers!

[weaverryan]

Hmm, I was very careful about these details, but indeed, I can’t think of why I would have done this intentionally. Looks like a bug - thanks for the report :)

[lenar]

Are you sure this is a bug? This would allow to use validations, otherwise the failure occurs too early.
I would say that currently there is a bug with ordinary fields which don't have ? before type if nullable=false. Failure occurs too early, makes it hard to validate. Maybe it should be configurable if one wants to allow nulls or not for setters.

[weaverryan]

Hmm, interesting. Are you using the form submit, and it’s submitting the values as null?

[lenar]

No, not using form submit. "Legacy" code, build with older Symfony releases. Manual validations with Symfony validation/constraint classes.

Anyway it should be selectable (by argument to console command) if you want very strict definitions (nulls not allowed if nullable=false and thus fail with PHP error) or you want to handle things yourself later with validations (and this seems to be the default with older releases and doctrine:generate:entitites).

And I really prefer handling nulls with validations and not manually modifying string => ?string in setters of generated entities.

[lenar]

Looking at older (doctrine:generate:..) generated entities, the setters are setSomething($something = null) irrelevant of nullable of column annotation. They were generated automatically. And it makes sense IMHO.

[javiereguiluz]

Even if this is correct in theory ... I'm afraid that in practice, when using Symfony Forms, is not correct. You must make everything nullable or the app won't work. That's why we did that in the Symfony Demo app for example: https://github.com/symfony/demo/blob/master/src/Entity/Post.php