Skip to content

[make:entity] generate() call to is_string() appears to always evaluate to false #1509

Open
@jrushlow

Description

@jrushlow

if (\is_string($manipulatorOrMessage)) {

I believe $manipulatorOrMessage is always an instance of ClassSourceManipulator but I may be wrong. This could be an artifact leftover from previous versions where we did display a message. We need to confirm what use case would cause this not to be an instance of CSM.

For debugging:

  • change the conditional to $manipulatorOrMessage instanceOf ClassSourceManipulator -> getSourceCode() && exit early.
  • then attach breakpoint || dump($manipulatorOrMessage) in the else statement.

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugBug Fix

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions