Skip to content

Wrote tests #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DataCollector/TimeDataCollector.php
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public function collect(Request $request, Response $response, \Throwable $except

public function reset()
{
$this->data = [];
$this->data = ['events' => [], 'start_time' => 0];

$this->stopwatch?->reset();
}
Expand Down
82 changes: 82 additions & 0 deletions Tests/DataCollector/RouterDataCollectorTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
<?php

namespace Symfony\Component\HttpKernel\Tests\DataCollector;

use PHPUnit\Framework\TestCase;
use Symfony\Component\Config\Loader\LoaderInterface;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\DataCollector\RouterDataCollector;
use Symfony\Component\HttpKernel\Event\ControllerEvent;
use Symfony\Component\HttpKernel\Kernel;
use Symfony\Component\HttpKernel\KernelInterface;

class RouterDataCollectorTest extends TestCase
{
public function testRouteRedirectResponse()
{
$collector = new RouterDataCollector();

$request = Request::create('http://test.com/foo?bar=baz');
$response = new RedirectResponse('http://test.com/redirect');

$event = $this->createControllerEvent($request);

$collector->onKernelController($event);
$collector->collect($request, $response);

$this->assertTrue($collector->getRedirect());
$this->assertEquals('http://test.com/redirect', $collector->getTargetUrl());
$this->assertEquals('n/a', $collector->getTargetRoute());
}

public function testRouteNotRedirectResponse()
{
$collector = new RouterDataCollector();

$request = Request::create('http://test.com/foo?bar=baz');
$response = new Response('test');

$event = $this->createControllerEvent($request);

$collector->onKernelController($event);
$collector->collect($request, $response);

$this->assertFalse($collector->getRedirect());
$this->assertNull($collector->getTargetUrl());
$this->assertNull($collector->getTargetRoute());
}

public function testReset()
{
$collector = new RouterDataCollector();

// Fill Collector
$request = Request::create('http://test.com/foo?bar=baz');
$response = new RedirectResponse('http://test.com/redirect');
$event = $this->createControllerEvent($request);
$collector->onKernelController($event);
$collector->collect($request, $response);

$collector->reset();

$this->assertFalse($collector->getRedirect());
$this->assertNull($collector->getTargetUrl());
$this->assertNull($collector->getTargetRoute());
}

public function testGetName()
{
$collector = new RouterDataCollector();

$this->assertEquals('router', $collector->getName());
}

protected function createControllerEvent(Request $request)
{
$kernel = $this->createMock(KernelInterface::class);

return new ControllerEvent($kernel, function () {}, $request, null);
}
}
100 changes: 100 additions & 0 deletions Tests/DataCollector/TimeDataCollectorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
use Symfony\Component\HttpKernel\DataCollector\TimeDataCollector;
use Symfony\Component\HttpKernel\KernelInterface;
use Symfony\Component\Stopwatch\Stopwatch;
use Symfony\Component\Stopwatch\StopwatchEvent;

/**
* @group time-sensitive
Expand Down Expand Up @@ -55,4 +56,103 @@ public function testCollect()
$this->assertEquals(123456000, $c->getStartTime());
$this->assertSame(class_exists(Stopwatch::class, false), $c->isStopwatchInstalled());
}

public function testReset()
{
$collector = new TimeDataCollector();

// Fill Collector
$request = Request::create('http://test.com/foo?bar=baz');
$response = new Response('test');
$collector->collect($request, $response);

$collector->reset();

$this->assertEquals([], $collector->getEvents());
$this->assertEquals(0, $collector->getStartTime());
}

public function testLateCollect()
{
$stopwatch = new Stopwatch();
$stopwatch->start('test');

$collector = new TimeDataCollector(null, $stopwatch);

$request = new Request();
$request->attributes->set('_stopwatch_token', '__root__');

$collector->collect($request, new Response());
$collector->lateCollect();

$this->assertEquals(['test'], array_keys($collector->getEvents()));
}

public function testSetEvents()
{
$collector = new TimeDataCollector();

$event = $this->createMock(StopwatchEvent::class);
$event->expects($this->once())->method('ensureStopped');

$events = [$event];

$collector->setEvents($events);

$this->assertCount(1, $collector->getEvents());
}

public function testGetDurationHasEvents()
{
$collector = new TimeDataCollector();

$request = new Request();
$request->server->set('REQUEST_TIME_FLOAT', 1);
$collector->collect($request, new Response());

$event = $this->createMock(StopwatchEvent::class);
$event->expects($this->once())->method('getDuration')->willReturn(2000.0);
$event->expects($this->once())->method('getOrigin')->willReturn(1000.0);
$events = ['__section__' => $event];
$collector->setEvents($events);

$this->assertEquals(1000 + 2000 - 1000, $collector->getDuration());
}

public function testGetDurationNotEvents()
{
$collector = new TimeDataCollector();

$this->assertEquals(0, $collector->getDuration());
}

public function testGetInitTimeNotEvents()
{
$collector = new TimeDataCollector();

$this->assertEquals(0, $collector->getInitTime());
}

public function testGetInitTimeHasEvents()
{
$collector = new TimeDataCollector();

$request = new Request();
$request->server->set('REQUEST_TIME_FLOAT', 1);
$collector->collect($request, new Response());

$event = $this->createMock(StopwatchEvent::class);
$event->expects($this->once())->method('getOrigin')->willReturn(2000.0);
$events = ['__section__' => $event];
$collector->setEvents($events);

$this->assertEquals(2000 - 1000, $collector->getInitTime());
}

public function testGetName()
{
$collector = new TimeDataCollector();

$this->assertEquals('time', $collector->getName());
}
}