Changing to support next version of stimulus bridge with "fetch" mode #735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if you want to avoid a hard break, you could actually set both keys in Flex. stimulus-bridge will ignore the key it does not need. |
I've just done that 👍 symfony/ux#53
👍 It indeed does this :) |
weaverryan
commented
Feb 1, 2021
| { | ||
| $this->tempDir = sys_get_temp_dir().'/flex-package-json-'.substr(md5(uniqid('', true)), 0, 6); | ||
| (new Filesystem())->mirror(__DIR__.'/Fixtures/packageJson', $this->tempDir); | ||
|
|
||
| $this->synchronizer = new PackageJsonSynchronizer($this->tempDir); | ||
| } | ||
|
|
||
| public function tearDown(): void | ||
| protected function tearDown(): void |
There was a problem hiding this comment.
fabbot-motivated change
weaverryan
commented
Feb 1, 2021
| @@ -149,7 +149,7 @@ private function registerWebpackResources(array $phpPackages) | |||
| } | |||
| } | |||
|
|
|||
| file_put_contents($controllersJsonPath, json_encode($newControllersJson, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES)."\n"); | |||
| file_put_contents($controllersJsonPath, json_encode($newControllersJson, \JSON_PRETTY_PRINT | \JSON_UNESCAPED_SLASHES)."\n"); | |||
tgalopin
added a commit
to symfony/ux
that referenced
this pull request
Feb 1, 2021
…ge#15 (weaverryan) This PR was merged into the main branch. Discussion ---------- Changing webpackMode to fetch - see symfony/stimulus-bridge#15 | Q | A | ------------- | --- | Bug fix? | yes(ish) | New feature? | no | Tickets | none | License | MIT Hi! If symfony/stimulus-bridge#15 is merged, this updates the keys for all the UX packages. The old `webpackMode` is kept for now. This will prevent errors if you're using an "old" Flex version (a version before this PR symfony/flex#735). We can remove that... eventually... Cheers! Commits ------- 27f7115 Adding fetch - see symfony/stimulus-bridge#15
nicolas-grekas
approved these changes
Feb 1, 2021
|
Thanks @weaverryan. |
fullstackdeveloperwebapp
added a commit
to fullstackdeveloperwebapp/ux
that referenced
this pull request
Aug 1, 2023
…ge#15 (weaverryan) This PR was merged into the main branch. Discussion ---------- Changing webpackMode to fetch - see symfony/stimulus-bridge#15 | Q | A | ------------- | --- | Bug fix? | yes(ish) | New feature? | no | Tickets | none | License | MIT Hi! If symfony/stimulus-bridge#15 is merged, this updates the keys for all the UX packages. The old `webpackMode` is kept for now. This will prevent errors if you're using an "old" Flex version (a version before this PR symfony/flex#735). We can remove that... eventually... Cheers! Commits ------- 27f7115 Adding fetch - see symfony/stimulus-bridge#15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partner to symfony/stimulus-bridge#15 and symfony/ux#53
The tricky part about this is that, if the user has
stimulus-bridge1.x, then theircontrollers.jsonfile needswebpackMode. If they havestimulus-bridge"next" (we're thinking it'll be 2.0), then theircontrollers.jsonfile needsfetch. This means that Flex has a "hard break" and sorta just needs to assume that the user has the "new" version.We made the decision - to go from
webpackModetofetchbecause the setting no longer is truly the same aswebpackMode. However, if we wanted to make the upgrade path easier, we could revert that and usewebpackModein 2.0 as well (instead of changing tofetch).