Skip to content

Unpack by default when running composer require #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Unpack by default when running composer require #656

merged 1 commit into from
Jul 14, 2020

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jul 10, 2020

Packs are like meta-recipes: ppl should adopt them in their root composer.json so that updating packs (like updating recipes) doesn't affect their project.

If one needs to delegate the selection of a group of packages, they should use the meta-package type of composer instead.

Fixes #645

@stof
Copy link
Member

stof commented Jul 10, 2020

This will make composer require and composer require --unpack being exactly the same, with only composer require --unpack=false skipping it. This is a confusing API IMO. A --no-unpack flag would be easier to understand.

@nicolas-grekas
Copy link
Member Author

@stof updated. This requires deprecating --unpack.

@nicolas-grekas nicolas-grekas changed the title Unpack by default when running compose require Unpack by default when running composer require Jul 13, 2020
@fabpot
Copy link
Member

fabpot commented Jul 14, 2020

Thank you @nicolas-grekas.

@fabpot fabpot merged commit afd3d71 into symfony:master Jul 14, 2020
@nicolas-grekas nicolas-grekas deleted the auto-unpack branch August 25, 2020 08:23
tgalopin pushed a commit to tgalopin/flex that referenced this pull request Dec 3, 2020
andrew-demb added a commit to andrew-demb/symfony-docs that referenced this pull request Jan 11, 2021
…anged

`symfony/flex` since `1.9.0` unpack packs by default (PR symfony/flex#656)
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Jan 11, 2021
…lex changed (andrew-demb)

This PR was merged into the 4.4 branch.

Discussion
----------

Fixes #14814 Default behavior about unpacking packs by Flex changed

`symfony/flex` since `1.9.0` unpack packs by default (PR symfony/flex#656)

Text proposed by @wouterj (thank you!) in comment #14814 (comment)

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `5.x` for features of unreleased versions).

-->

Commits
-------

5e74358 Fixes #14814 Default behavior about unpacking packs by Flex changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit the way packs work - always unpack them
5 participants