Fix unpack logic #1050
Merged
Fix unpack logic #1050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
fix-unpack
branch
from
450215d to
a8b88c4
Compare
|
/cc @alexpott you might be interested in this additional logic (fixing composer require reinserting the pack in composer.json even if the plugin removed it and removing anything from the pack in the vendor/ dir) |
nicolas-grekas
force-pushed
the
fix-unpack
branch
from
a8b88c4 to
188dfc8
Compare
nicolas-grekas
force-pushed
the
fix-unpack
branch
3 times, most recently
from
d8345ff to
83bc68d
Compare
nicolas-grekas
force-pushed
the
fix-unpack
branch
from
83bc68d to
d66470c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1030
and a few other things when unpacking packs.
Working on tests now.