Do not check errored definitions’ type

symfony · May 5, 2023 · 4645e03 · 4645e03
1 parent bb7b798
commit 4645e03
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 1 deletion.
diff --git a/Compiler/CheckTypeDeclarationsPass.php b/Compiler/CheckTypeDeclarationsPass.php
@@ -210,7 +210,7 @@ private function checkType(Definition $checkedDefinition, $value, \ReflectionPar
         $class = null;
 
         if ($value instanceof Definition) {
-            if ($value->getFactory()) {
+            if ($value->hasErrors() || $value->getFactory()) {
                 return;
             }
 

diff --git a/Tests/Compiler/CheckTypeDeclarationsPassTest.php b/Tests/Compiler/CheckTypeDeclarationsPassTest.php
@@ -23,6 +23,7 @@
 use Symfony\Component\DependencyInjection\ParameterBag\EnvPlaceholderParameterBag;
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeDeclarationsPass\Bar;
+use Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeDeclarationsPass\BarErroredDependency;
 use Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeDeclarationsPass\BarMethodCall;
 use Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeDeclarationsPass\BarOptionalArgument;
 use Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeDeclarationsPass\BarOptionalArgumentNotNull;
@@ -1010,6 +1011,20 @@ public function testIgnoreDefinitionFactoryArgument()
 
         $this->addToAssertionCount(1);
     }
+
+    public function testErroredDefinitionsAreNotChecked()
+    {
+        $container = new ContainerBuilder();
+        $container->register('errored_dependency', BarErroredDependency::class)
+            ->setArguments([
+                (new Definition(Foo::class))
+                    ->addError('error'),
+            ]);
+
+        (new CheckTypeDeclarationsPass(true))->process($container);
+
+        $this->addToAssertionCount(1);
+    }
 }
 
 class CallableClass

diff --git a/Tests/Fixtures/CheckTypeDeclarationsPass/BarErroredDependency.php b/Tests/Fixtures/CheckTypeDeclarationsPass/BarErroredDependency.php
@@ -0,0 +1,10 @@
+<?php
+
+namespace Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeDeclarationsPass;
+
+class BarErroredDependency
+{
+    public function __construct(\stdClass $foo)
+    {
+    }
+}