[PHP CS Fixer] Update the config #1611
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosier
commented
Oct 9, 2025
| ->notPath('public/index.php') | ||
| ->notPath('importmap.php') | ||
| ; | ||
|
|
There was a problem hiding this comment.
The current Finder config first includes the whole project dir and then basically excludes everything but 'src' and 'tests'. This can be simplified to include just 'src' and 'tests'.
| 'no_useless_else' => true, | ||
| 'no_useless_return' => true, | ||
| 'php_unit_strict' => true, | ||
| 'phpdoc_order' => true, |
There was a problem hiding this comment.
This rule is also part of the Symfony ruleset but with a different order. To me it makes more sense for the Symfony Demo Application to use the same order as the Symfony project.
| 'phpdoc_order' => true, | ||
| 'strict_comparison' => true, | ||
| 'strict_param' => true, | ||
| 'blank_line_between_import_groups' => false, |
There was a problem hiding this comment.
This rule is set to the opposite of the rule that is part of the Symfony ruleset. Again I think it makes more sense to follow the Symfony project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the Finder config and removes the rules that are already part of the Symfony ruleset