Skip to content

Use bootstrap 5 form theme #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions config/packages/twig.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
twig:
default_path: '%kernel.project_dir%/templates'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file_name_pattern: '*.twig'
form_themes:
- 'form/layout.html.twig'
- 'bootstrap_5_layout.html.twig'
- 'form/fields.html.twig'
file_name_pattern: '*.twig'

when@test:
twig:
Expand Down
16 changes: 0 additions & 16 deletions templates/form/layout.html.twig

This file was deleted.

5 changes: 4 additions & 1 deletion tests/Controller/Admin/BlogControllerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,11 @@ public function testAdminNewDuplicatedPost(): void
// post titles must be unique, so trying to create the same post twice should result in an error
$this->client->submit($form);

$this->assertSelectorTextContains('form .invalid-feedback .form-error-message', 'This title was already used in another blog post, but they must be unique.');
$this->assertSelectorExists('form #post_title.is-invalid');
$this->assertSelectorTextContains(
'form .invalid-feedback',
'This title was already used in another blog post, but they must be unique.'
);
}

public function testAdminShowPost(): void
Expand Down
Loading