Skip to content

php8: fixed named arguments order #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

COil
Copy link
Contributor

@COil COil commented Feb 14, 2023

This is to fix:

Capture d’écran 2023-02-14 à 22 25 44

@derrabus
Copy link
Member

There's nothing to fix here. That PhpStorm inspection is pointless and disabling it gives me peace of mind in every codebase I've worked on so far. 😌

@COil
Copy link
Contributor Author

COil commented Feb 14, 2023

There's nothing to fix here. That PhpStorm inspection is pointless and disabling it gives me peace of mind in every codebase I've worked on so far. 😌

Yes, but it's mainly for consistency to avoid having different orders everywhere. It should/could be a php-cs-fixer rule.

Is there a reason we don't use php-cs-fixer in this project?

@OskarStark
Copy link
Contributor

You are right from a technical POV @derrabus, but I would argue that most of the devs write it in the from @COil proposed order anyway. That said I am +1 to merge this change.

This repo ist mostly for newcomers 🤷🏼‍♂️

Copy link
Member

@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For enforcing consistency

@javiereguiluz javiereguiluz force-pushed the chore/named-arguments-order branch from ad24060 to 5eefef1 Compare February 15, 2023 08:27
@javiereguiluz
Copy link
Member

I agree with all of you ... but there seems to be more people in favor of merging this, so let's do it. Thanks Loïc!

@javiereguiluz javiereguiluz merged commit 84ae312 into symfony:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants