Skip to content

Add some doc for Twig Extension #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2021
Merged

Add some doc for Twig Extension #1290

merged 1 commit into from
Dec 20, 2021

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Dec 16, 2021

While reading the doc and opening symfony/symfony-docs#16292 as well

@94noni
Copy link
Contributor Author

94noni commented Dec 17, 2021

@bocharsky-bw thanks for the first approval
I've reworded the comment to point to the documentation instead, perhaps a new check would be great, thank you

bocharsky-bw
bocharsky-bw approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better 👍

@javiereguiluz
Copy link
Member

Thank you Antoine.

@javiereguiluz javiereguiluz merged commit 8e8d63c into symfony:main Dec 20, 2021
@94noni 94noni deleted the ft-twig-ext-doc branch December 20, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bocharsky-bw bocharsky-bw bocharsky-bw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@94noni @javiereguiluz @bocharsky-bw