-
-
Notifications
You must be signed in to change notification settings - Fork 112
add support for the albert platform configuration #837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
53a0248 to
a6c8ea1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the Albert AI platform to the Symfony AI bundle. Albert is an AI platform provided by the French government (etalab.gouv.fr).
Key changes:
- Added Albert platform configuration with required
api_keyandbase_urlfields - Integrated Albert platform factory into the dependency injection container
- Updated test fixtures to include Albert configuration
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ai-bundle/config/options.php | Added Albert platform configuration schema with api_key, base_url, and http_client options |
| src/ai-bundle/src/AiBundle.php | Added Albert platform factory registration and service definition |
| src/ai-bundle/tests/DependencyInjection/AiBundleTest.php | Added Albert platform configuration to test fixtures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d7e9fe1 to
41e7518
Compare
|
Quick update: I added support for providing a custom ModelCatalog in the factory, so the Albert platform configuration is now consistent with the other platforms. Also, regarding the model list: I saw that the alignment work was already merged, so that part is resolved (#839). One open point from the original description: Albert currently uses Related to that: should we provide a default |
41e7518 to
60c6889
Compare
71aa87e to
154621c
Compare
|
could you please squash the two commits? |
- Add Albert platform configuration and service definitions. - Make platform factory accept a customizable ModelCatalog instance.
154621c to
0e846d2
Compare
This PR introduces support for configuring the Albert platform under the
ai.platformssection, following the pattern of existing platforms (OpenAI, Mistral, Ollama, etc.).The underlying Albert integration was already implemented, but the
albertplatform key was not recognized during configuration parsing.The configuration uses
base_urlbecause this is the parameter expected by the Albert platform factory.Some platforms use
hostinstead, which might cause confusion. If needed, I'm open to aligning naming conventions in a follow-up discussion.I did not define a default
base_url, but we could consider providing the known Albert endpoint (https://albert.api.etalab.gouv.fr/v1) if that aligns with the project’s policy on defaults.While working on this, I also noticed that the list of Albert models may not be fully aligned with the current API. I can open a separate issue to track that, unless this work is already in progress.