[Store] Add ManagedStoreInterface #328
Conversation
Guikingone
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
carsonbot
added
Feature
OskarStark
changed the title
OskarStark
left a comment
OskarStark
left a comment
There was a problem hiding this comment.
No docs to adjust or changelog?
|
Yes, need to work on the changelog and tests, won't update the changelog until the tests are fixed 🙂 Regarding the documentation, the current state is that |
|
Just change the class name in the changelog as we haven't released yet |
|
Can you create an issue for creating the commands? Thanks |
Guikingone
force-pushed
the
store/managed_refactoring
branch
from
b6efbd5 to
cec347c
Compare
carsonbot
added
Status: Needs Work
Status: Needs Review
and removed
Status: Reviewed
Status: Needs Work
labels
Guikingone
force-pushed
the
store/managed_refactoring
branch
from
a8e826e to
c2a17e4
Compare
|
oh wow, nice one 💪 needs a rebase tho after #288 |
Guikingone
force-pushed
the
store/managed_refactoring
branch
from
c2a17e4 to
7abbb1f
Compare
chr-hertel
left a comment
chr-hertel
left a comment
There was a problem hiding this comment.
Thanks for that @Guikingone!
Didn't test it - and honestly wouldn't know how at this point. The PHPUnit tests won't be sufficient going forward.
For the other integrations we currently use the examples and the runner for doing integration tests - when we bring in the management commands we should also think about some integration test layer here with all the store bridges.
chr-hertel
force-pushed
the
store/managed_refactoring
branch
from
7abbb1f to
35aec00
Compare
|
Thank you @Guikingone. |
…Stark) This PR was merged into the main branch. Discussion ---------- [Store] Remove obsolete `DroppableStoreInterface` | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Docs? | no | Issues | Follows #328 | License | MIT Commits ------- 051a609 [Store] Remove obsoloete `DroppableStoreInterface`
…ngone) This PR was merged into the main branch. Discussion ---------- [Chat] Add interfaces for MessageStore management | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Docs? | yes | Issues | Fix none | License | MIT Hi 👋🏻 This PR introduce a new interface like in #328, this PR would allow to add commands later and improve the storage part of the `Chat` component. Commits ------- 1d080de feat(chat): add interface for management
4 participants
Hi 👋🏻
This PR aim to introduce the
ManagedStoreInterfaceas discussed in #285,Storeis a critical part of this library so I'm not gonna pretend that I know how each store currently work but here's the refactoring for most of them, tests must be improved but here's the first "draft".This PR does not include the related commands.