[Store] Add SurrealDB #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guikingone
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
Guikingone
force-pushed
the
store/surrealdb
branch
from
8c9ad55 to
e9b7322
Compare
Contributor
|
We just created some Thanks |
chr-hertel
requested changes
Jul 17, 2025
Member
chr-hertel
left a comment
chr-hertel
left a comment
There was a problem hiding this comment.
You're really on a great streak here to level up the store bridges - thanks for that! 🙏
Somehow the example doesn't work for me again - see below
chr-hertel
reviewed
Jul 18, 2025
Guikingone
force-pushed
the
store/surrealdb
branch
from
e9b7322 to
e38a096
Compare
Contributor
Author
|
@OskarStark 👋🏻 I updated the |
Contributor
|
Needs a rebase please |
chr-hertel
requested changes
Jul 18, 2025
Member
chr-hertel
left a comment
chr-hertel
left a comment
There was a problem hiding this comment.
small things about the inner contract of the Store implementation here
Guikingone
force-pushed
the
store/surrealdb
branch
from
e38a096 to
23ab86a
Compare
chr-hertel
reviewed
Jul 18, 2025
OskarStark
reviewed
Jul 18, 2025
Guikingone
force-pushed
the
store/surrealdb
branch
from
23ab86a to
6e82e2f
Compare
chr-hertel
approved these changes
Jul 20, 2025
chr-hertel
force-pushed
the
store/surrealdb
branch
from
6e82e2f to
a14c19d
Compare
Member
|
Thank you @Guikingone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋🏻
This PR aim to introduce
SurrealDBas a store for embeddings, the store use theHTTPAPI as the PHP SDK is ugly to use (and does not allow mocks), the tests needs to be improved / completed but the main implementation is ready.PS: By default, we can't send more than
1275embeddings during the insertion phase, the SDK can bypass this limitation but again, testing issues, API and more so, the road to follow is up to the team.