Combined early merges #130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bauersimon
reviewed
May 17, 2024
bauersimon
reviewed
May 17, 2024
ruiAzevedo19
force-pushed
the
combined-early-merges
branch
from
2fb81f4 to
d0ca132
Compare
ruiAzevedo19
force-pushed
the
combined-early-merges
branch
from
d0ca132 to
cf1c84c
Compare
zimmski
reviewed
May 18, 2024
| // AllAssessmentKeysStrings returns all registered assessment keys as strings. | ||
| AllAssessmentKeysStrings []string | ||
|
|
||
| // pointsPerAssessment holds the points awarded for a specific assessment. |
Member
There was a problem hiding this comment.
COmmit subject "Redo the coverage logic" same rules as internally. What, and why.
zimmski
reviewed
May 18, 2024
| ResultPath string `long:"result-path" description:"Directory path where results should be written to. The placeholder \"%datetime%\" can be used for the current date and time." default:"evaluation-%datetime%"` | ||
| // Runs holds the number of runs to perform. | ||
| Runs uint `long:"runs" description:"Number of runs to perform." default:"1"` | ||
| Runs uint64 `long:"runs" description:"Number of runs to perform." default:"1"` |
Member
There was a problem hiding this comment.
Commit subject: not for longer values, but to be consistent explicitly.
zimmski
reviewed
May 18, 2024
| assessments := report.NewAssessmentPerModelPerLanguagePerRepository(maps.Values(modelsSelected), maps.Values(languagesSelected), command.Repositories) | ||
| problemsPerModel := map[string][]error{} | ||
| { | ||
| for r := uint(0); r < command.Runs; r++ { |
Member
There was a problem hiding this comment.
Early merging this commit. @ruiAzevedo19 when you do an early merger, please always make sure that the commits you are adding are working. don't work on features in an early merger, instead, early merge.
zimmski
reviewed
May 18, 2024
|
|
||
| dataPath := filepath.Join(testDataPath, repositoryPath) | ||
|
|
||
| temporaryPath, err := os.MkdirTemp("", "eval-dev-quality") |
Member
There was a problem hiding this comment.
Not a workaround. It is a fix until we have a better solution. ALso. why is missing.
Member
|
Closing because first two commits have been merged, and last one will be dealt with in favor of #124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.