π is not a number

[Wrzlprmft]

from symengine import pi
print(pi.is_number)

is_number returns None for pi, though it should be True.

[grubdragon]

Can I work on this?

[Wrzlprmft]

I suppose so. Your contribution will have to be checked in a pull request anyway. Worst that can happen is that somebody coincidentally works on this at the same time, making your work redundant – but that’s extremely unlikely.

[grubdragon]

Okay, anything I should find out before starting? This is my first issue actually.

[Wrzlprmft]

While you can do this afterwards, it pays off to make yourself familiar with (topic) branches in Git and the pull-request system (you can find some information here). Also, take a look at the contributing guidelines. Finally, I recommend some basic familiarity with the concept of software testing, if you don’t have that already.

[grubdragon]

Okay, sure! I am familiar with the basics of git, and have looked through the guidelines. I do lack exposure to software testing, so I would be grateful for any resources. Thanks for everything!

[Wrzlprmft]

I would have to search for good beginner’s resources myself, but this Wikipedia section should suffice. The most important thing is that there are automated tests (which should succeed) and if you add a new functionality or fix a bug, you should write a test for this. For example, for this problem, you could start by writing a test that fails because π is not a number. Then you try to rewrite the main code such that this test (and all others) succeed.