Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an application where I want to use an
OrderedDict
(fromOrderedCollections.jl
) withsubs
, but some methods are too strictly typed. This PR widens the type fromDict
to the more genericAbstractDict
for the relevant methods.Update: Turns out that I did not need this for my app, see below, but I think the changes are still useful.
My initial motivation for using an
OrderedDict
instead of just callingsubs(eq, x => y)
repeatedly and in the right order was that I thought the former is faster.But it turned out that the benchmark I did was wrong, because of the following
I think the issue is that the first version is translated to
subs(subs(a+b, a=>b), b=>c)
, whereas the dict version somehow performs both substitutions at the same time.