Skip to content

task: fix missing tx meta #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2022
Merged

task: fix missing tx meta #839

merged 2 commits into from
May 30, 2022

Conversation

@AnthonyLaw
Copy link
Member

@AnthonyLaw AnthonyLaw commented May 27, 2022

What was the issue?

  • The SDK transaction DTO was missing some info such as meta's timestamp and feeMultiplier.

What's the fix?

  • added missing properties in transaction dto
{
    ...
    feeMultiplier: number,
    timestamp: UInt64
}
  • update all the unit test

@AnthonyLaw AnthonyLaw merged commit 5d60455 into dev May 30, 2022
@AnthonyLaw AnthonyLaw deleted the fix/missing-tx-meta branch May 30, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jaguar0625 Jaguar0625 Jaguar0625 approved these changes

@yilmazbahadir yilmazbahadir Awaiting requested review from yilmazbahadir

@0x6861746366574 0x6861746366574 Awaiting requested review from 0x6861746366574

@gimre-xymcity gimre-xymcity Awaiting requested review from gimre-xymcity

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AnthonyLaw @Jaguar0625