Skip to content

Moved default fetch from RepositoryFactoryHttp.ts to Http.ts #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Moved default fetch from RepositoryFactoryHttp.ts to Http.ts #619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/infrastructure/Http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { NetworkType } from '../model/network/NetworkType';
import { Page } from './Page';
import { QueryParams } from './QueryParams';
import { RepositoryCallError } from './RepositoryCallError';
import fetch from 'node-fetch';

/**
* Http extended by all http services
Expand Down Expand Up @@ -99,7 +100,8 @@ export abstract class Http {
}

public config(): Configuration {
return new Configuration({ basePath: this.url, fetchApi: this.fetchApi, queryParamsStringify: querystring });
const fetchApi = this.fetchApi || (typeof window !== 'undefined' && window.fetch.bind(window)) || fetch;
return new Configuration({ basePath: this.url, fetchApi: fetchApi, queryParamsStringify: querystring });
}

/**
Expand Down
3 changes: 1 addition & 2 deletions src/infrastructure/RepositoryFactoryHttp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ import { TransactionHttp } from './TransactionHttp';
import { TransactionRepository } from './TransactionRepository';
import { TransactionStatusHttp } from './TransactionStatusHttp';
import { TransactionStatusRepository } from './TransactionStatusRepository';
import fetch from 'node-fetch';
/**
* Receipt http repository.
*
Expand All @@ -69,7 +68,7 @@ export class RepositoryFactoryHttp implements RepositoryFactory {
*/
constructor(url: string, configs?: RepositoryFactoryConfig) {
this.url = url;
this.fetchApi = configs?.fetchApi || (typeof window !== 'undefined' && window.fetch.bind(window)) || fetch;
this.fetchApi = configs?.fetchApi;
this.networkType = configs?.networkType
? observableOf(configs.networkType)
: this.createNetworkRepository().getNetworkType().pipe(shareReplay(1));
Expand Down