Skip to content

Alias resolution for accountHttp #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from Apr 20, 2020
Merged

Alias resolution for accountHttp #540

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6e5c4a0
Fixed #499
rg911 Apr 16, 2020
4323b31
Fixed e2e tests
rg911 Apr 16, 2020
174f5a3
Fixed lints
rg911 Apr 16, 2020
9fd93bf
Fixed years
rg911 Apr 16, 2020
08e19c2
another year fix
rg911 Apr 16, 2020
3f49ef1
Merge branch 'master' into task/g499_resolve_alias
rg911 Apr 16, 2020
6d3c079
Chaned to use address array and reduce rest calls
rg911 Apr 16, 2020
d8dda68
handle empty array
rg911 Apr 16, 2020
65cb1db
Merge branch 'master' into task/g499_resolve_alias
rg911 Apr 17, 2020
73e9929
Merge branch 'master' into task/g499_resolve_alias
rg911 Apr 17, 2020
12e9293
Fixed typos
rg911 Apr 20, 2020
e4d518a
more typo fix
rg911 Apr 20, 2020
fa02e96
Fixed function name
rg911 Apr 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixed function name
  • Loading branch information
@rg911
rg911 committed Apr 20, 2020
commit fa02e9655e4a367e054fb38bd235379c9c1384a8
4 changes: 2 additions & 2 deletions src/service/AccountService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export class AccountService implements IAccountService {
const accountInfoObservable = this.accountRepository.getAccountsInfo(addresses);
const distinctNames = accountInfoObservable.pipe(
mergeMap((info) => {
const namespaceIds = this.getDistinctNamespaceIdFromAccountInfors(info);
const namespaceIds = this.getDistinctNamespaceIdFromAccountInfos(info);
if (namespaceIds.length) {
return this.namespaceRepository.getNamespacesName(namespaceIds);
}
Expand Down Expand Up @@ -121,7 +121,7 @@ export class AccountService implements IAccountService {
* @param accountInfos List of account infos
* @returns {NamespaceId[]}
*/
private getDistinctNamespaceIdFromAccountInfors(accountInfos: AccountInfo[]): NamespaceId[] {
private getDistinctNamespaceIdFromAccountInfos(accountInfos: AccountInfo[]): NamespaceId[] {
const namespaceIds: NamespaceId[] = [];
accountInfos.forEach((info) => {
info.mosaics.forEach((mosaic) => {
Expand Down