Skip to content

[JAV-52, JAV-54, JAV-57, JAV-27, JAV-58, JAV-59] Small issue fixes #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rg911 merged 22 commits into from
Oct 8, 2019
Merged

[JAV-52, JAV-54, JAV-57, JAV-27, JAV-58, JAV-59] Small issue fixes #284

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
9863862
JAV-52 [github #276] Fixed mosaicAmountView observable issue
rg911 Oct 4, 2019
b8bbd1b
JAV-54 [Github #277] Improved AccountRestriction payload
rg911 Oct 4, 2019
78dd1eb
JAV-57 [Github #285] Fixed error handling issue
rg911 Oct 5, 2019
b7d116a
JAV-27 [Github #246] Fixed Alias issue
rg911 Oct 5, 2019
fb09d73
Added @interal for abstract mathod
rg911 Oct 5, 2019
7e6a770
JAV-58 [Github #286] Fixed MosaicId significant byte not detected
rg911 Oct 6, 2019
cb426f3
Implement KeyGenerator
contractormario Oct 7, 2019
c061e4b
Merge branch 'master' into task/g278_key_generator
contractormario Oct 7, 2019
e39cf99
Fix copyright, jsdoc and return value type. Remove regex
contractormario Oct 7, 2019
275a7ab
JAV-59 [Github #287] Fixed network http only allow MIJIN_TEST issue
rg911 Oct 7, 2019
b61506a
Changed metadataTransactionService key from string to UInt64
rg911 Oct 7, 2019
11934dc
Rename, relax validation, convert to arraybuf instead of hex
contractormario Oct 7, 2019
7615a42
Merge pull request #288 from contractormario/task/g278_key_generator
rg911 Oct 7, 2019
cb000ff
JAV-52 [github #276] Fixed mosaicAmountView observable issue
rg911 Oct 4, 2019
7271217
JAV-54 [Github #277] Improved AccountRestriction payload
rg911 Oct 4, 2019
df11c9f
JAV-57 [Github #285] Fixed error handling issue
rg911 Oct 5, 2019
266f064
JAV-27 [Github #246] Fixed Alias issue
rg911 Oct 5, 2019
7f3bbd0
Added @interal for abstract mathod
rg911 Oct 5, 2019
7acd163
JAV-58 [Github #286] Fixed MosaicId significant byte not detected
rg911 Oct 6, 2019
709680c
JAV-59 [Github #287] Fixed network http only allow MIJIN_TEST issue
rg911 Oct 7, 2019
e5e216f
Changed metadataTransactionService key from string to UInt64
rg911 Oct 7, 2019
62a384b
Merge branch 'small_fixes_prior_rc' of github.com:rg911/nem2-sdk-type…
rg911 Oct 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
JAV-58 [Github #286] Fixed MosaicId significant byte not detected
  • Loading branch information
@rg911
rg911 committed Oct 6, 2019
commit 7e6a77089c21aafb4c07e114841c375f13baeca1
2 changes: 1 addition & 1 deletion src/infrastructure/transaction/CreateTransactionFromDTO.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ export const extractMosaics = (mosaics: any): Mosaic[] => {
return mosaics.map((mosaicDTO) => {

// convert ID to UInt8 bytes array and get first byte (most significant byte)
const bytes = convert.hexToUint8(mosaicDTO.id).reverse();
const bytes = convert.hexToUint8(mosaicDTO.id);
const byte0 = bytes[0];

// if most significant bit of byte 0 is set, then we have a namespaceId
Expand Down