Fix mix node #113
Merged
Fix mix node #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/services/NodeMonitor.ts
Outdated
| @@ -54,10 +57,10 @@ export class NodeMonitor { | |||
| this.isRunning = true; | |||
| this.clear(); | |||
|
|
|||
| await this.getNetworkType(); // Read network Type from provided nodes. | |||
| await this.getNetworkInfo(); // Read network Type and generated hash seed from provided nodes. | |||
There was a problem hiding this comment.
Should we rename this method as it's not a getter method (doesn't return anything)?
How about fetchAndSetNetworkInfo?
Wayonb
requested changes
Nov 23, 2021
| return this.fetchNodesByURL(getNodeURL(node, monitor.API_NODE_PORT)); | ||
| const hostUrl = await ApiNodeService.buildHostUrl(node.host); | ||
|
|
||
| return this.fetchNodePeersByURL(hostUrl); |
There was a problem hiding this comment.
Maybe I miss it, are pulling node/peers from every api node?
yilmazbahadir
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node info from
/node/peerscan't be trusted, it always gives the wrong information, causing the node list to mix with another network.Add
networkGenerationHashSeedproperty in NodeMonitor classnetworkGenerationHashSeedon add node filter, to ensure always get the right node.Removed
NETWORK_IDENTIFIERbecause network type is always collected from the provided node.Update
fetchNodesByURL->fetchNodePeersByURLfetchNodePeersByURLmethod will only collect nodes from the node/peers.getNodeListInfomethod, collect nodes info (only API roles) without condition.