Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explorer/rest]: added namespace and namespaces endpoint #702

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from

Conversation

AnthonyLaw
Copy link
Member

@AnthonyLaw AnthonyLaw commented Nov 7, 2023

What was the issue?

  • Implement namespace and namespaces endpoint.

What's the fix?

  • Added search namespace by name.
  • Added search namespace listing.
  • Added unit test

@AnthonyLaw AnthonyLaw force-pushed the explorer/rest-namespaces-endpoint branch from 7e6d7f8 to 4f8e0cd Compare November 10, 2023 13:41
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #702 (38cea45) into dev (0f4f93e) will increase coverage by 0.02%.
Report is 3 commits behind head on dev.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #702      +/-   ##
==========================================
+ Coverage   98.22%   98.24%   +0.02%     
==========================================
  Files         161      162       +1     
  Lines        6537     6615      +78     
  Branches      143      143              
==========================================
+ Hits         6421     6499      +78     
  Misses        116      116              
Flag Coverage Δ
explorer-nodewatch 98.40% <ø> (ø)
explorer-rest 99.50% <100.00%> (+0.31%) ⬆️
faucet-authenticator 100.00% <ø> (ø)
faucet-backend 98.91% <ø> (ø)
faucet-frontend 100.00% <ø> (ø)
lightapi-python 98.35% <ø> (ø)
tools-shoestring 96.76% <ø> (ø)
tools-vanity 99.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
explorer/rest/rest/__init__.py 98.68% <100.00%> (+0.46%) ⬆️
explorer/rest/rest/db/NemDatabase.py 100.00% <100.00%> (ø)
explorer/rest/rest/facade/NemRestFacade.py 100.00% <100.00%> (ø)
explorer/rest/rest/model/Namespace.py 100.00% <100.00%> (ø)

@AnthonyLaw AnthonyLaw marked this pull request as ready for review November 10, 2023 16:29
@AnthonyLaw AnthonyLaw changed the title [explorer/rest]: added namespaces endpoint [explorer/rest]: added namespace and namespaces endpoint Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant