Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR Code reader not working (?) on Add Account > Scan Private Key QR #88

Open
Peersyst opened this issue Jan 11, 2021 · 3 comments · May be fixed by #221
Open

QR Code reader not working (?) on Add Account > Scan Private Key QR #88

Peersyst opened this issue Jan 11, 2021 · 3 comments · May be fixed by #221
Assignees
Labels
IOS IOS bug Mobile Needs Reproduction Requires test team to reproduce P3 Issue Minor issue with aesthetics Sprint 4

Comments

@Peersyst
Copy link

A user wrote that when trying to add account using the derivation path
"About create accounts. The QR code to read the mnemonic does not come out, and it seems that I can not add a watch even if I type the mnemonic. You can do it with a private key."

He was trying to use the seed index input to input his mnemonic

@Peersyst Peersyst added the enhancement New feature or request label Jan 11, 2021
@coiki
Copy link

coiki commented Aug 25, 2021

In mobile, Seems like the QR reader is working correctly when scanning a QR code for private key. Could we confirm this in the next sprint? @cryptoBeliever

Thanks.

@coiki
Copy link

coiki commented Aug 25, 2021

User story

As a user that is adding a new account,
I want to scan a QR code of a private key easily with my camera,
so I can add that account to my phone as fast and easy as possible.

Acceptance Criteria

AC1. I can scan with the camera a QR code when importing with a private key.

@coiki coiki changed the title Improve create account page QR Code reader not working (?) on Add Account > Scan Private Key QR Aug 25, 2021
@coiki coiki added Mobile Needs Reproduction Requires test team to reproduce Sprint 4 IOS IOS bug and removed enhancement New feature or request labels Aug 25, 2021
@cryptoBeliever cryptoBeliever self-assigned this Aug 25, 2021
@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Aug 27, 2021

@coiki
Private key QR scanning works fine.

"He was trying to use the seed index input to input his mnemonic" - I think user don't know what for this field is. We should not allow put text into field "Seed index (blank for automatic increase)". Only numbers should be allowed there (with some reasonable limit like 100). Basicly this field is generating account (based on current seed) with specific index and you can't put there mnemonic.

@cryptoBeliever cryptoBeliever removed their assignment Aug 27, 2021
@bassemmagdy bassemmagdy self-assigned this Sep 17, 2021
bassemmagdy added a commit that referenced this issue Sep 17, 2021
bassemmagdy added a commit that referenced this issue Sep 17, 2021
@bassemmagdy bassemmagdy linked a pull request Sep 17, 2021 that will close this issue
@cryptoBeliever cryptoBeliever added the P3 Issue Minor issue with aesthetics label Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IOS IOS bug Mobile Needs Reproduction Requires test team to reproduce P3 Issue Minor issue with aesthetics Sprint 4
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants