[explorer] task: hide hash lock section #1137
Conversation
✅ Deploy Preview for explorer-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@AnthonyLaw looks good 👍 Hash lock information is visible for aggregate bonded (in the partial and confirmed state): The hash lock section is not visible for other transaction types: |
src/views/PageAssembler.vue
Outdated
| if (Array.isArray(data)) { | ||
| return !!data.length; | ||
| } else { | ||
| return !!Object.keys(data).length |
There was a problem hiding this comment.
I guess this should work also for arrays, so nested if statement is not necessary here.
There was a problem hiding this comment.
Also I would suggest to change this part only to return false when hideEmptyData is true and Object.keys(data).length is 0.
Otherwise when hideEmptyData is positive, we will never reach the part below (and all errored views will be rendered):
[L138] if (item.hideOnError && this.getter(item.managerGetter)?.error)
There was a problem hiding this comment.
Also I would suggest to change this part only to return
falsewhenhideEmptyDatais true andObject.keys(data).lengthis 0.
Otherwise whenhideEmptyDatais positive, we will never reach the part below (and all errored views will be rendered):
[L138] if (item.hideOnError && this.getter(item.managerGetter)?.error)
that makes sense 👍🏼
AnthonyLaw
force-pushed
the
task/hide-hash-lock-section
branch
from
8119adb
to
c61a7e7
Compare
What was the issue?
What's the fix?
hideEmptyDataissue.