Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Use correct namespace for imports #508

Merged
merged 1 commit into from
Dec 14, 2023
Merged

FIX Use correct namespace for imports #508

merged 1 commit into from
Dec 14, 2023

Conversation

emteknetnz
Copy link
Collaborator

Issue #507

@emteknetnz emteknetnz mentioned this pull request Dec 14, 2023
Closed
GuySartorelli
GuySartorelli approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this wouldn't have been picked up in the past because there would be no error - it'd just go "nope that class doesn't exist" in the class_exists check and use the fallback.

@GuySartorelli GuySartorelli merged commit 2a46415 into symbiote:5.9 Dec 14, 2023
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5.9/import branch December 14, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli