Merge branch '5.9' into 5

symbiote · Sep 17, 2023 · e2cd3ff · e2cd3ff
2 parents 4573a82 + fd6e831
commit e2cd3ff
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/Extensions/WorkflowEmbargoExpiryExtension.php b/src/Extensions/WorkflowEmbargoExpiryExtension.php
@@ -182,7 +182,7 @@ public function updateCMSFields(FieldList $fields)
     public function clearPublishJob()
     {
         $job = $this->owner->PublishJob();
-        if ($job && $job->exists()) {
+        if ($job && $job->exists() && !$job->JobFinished) {
             $job->delete();
         }
         $this->owner->PublishJobID = 0;
@@ -195,7 +195,7 @@ public function clearUnPublishJob()
     {
         // Cancel any in-progress unpublish job
         $job = $this->owner->UnPublishJob();
-        if ($job && $job->exists()) {
+        if ($job && $job->exists() && !$job->JobFinished) {
             $job->delete();
         }
         $this->owner->UnPublishJobID = 0;
@@ -299,6 +299,10 @@ public function onBeforeWrite()
         if (!$this->owner->ID) {
             return;
         }
+
+        if ($this->owner->hasMethod('isPublishJobRunning') && $this->owner->isPublishJobRunning()) {
+            return;
+        }
 
         // Check requested dates of publish / unpublish, and whether the page should have already been unpublished
         $now = DBDatetime::now()->getTimestamp();