Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(MarkdownCleaner): Be able to ignore comments, lines and front matter #182

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Fix(MarkdownCleaner): Be able to ignore comments, lines and front matter #182

merged 2 commits into from
Jul 26, 2021

Conversation

daniel-vera-g
Copy link
Contributor

Changes:

  • Ignore regular, inline and multiline comments
  • Be able to ignore parts of the text
  • Ignore front matter
  • Update README
  • MarkdownCleaner Tests for changes
  • Slight refactoring of the Ignore text

Cases considered

  1. Regular comment:

<!-- Regular comment -->

  1. Inline comment: <!-- Inline comment -->
  2. Multiline comment:
Some text <!-- A
multiline
comment --> also here
  1. Ignore comments:
  • Start ignoring lines after: <!-- textidote: ignore begin -->
  • Stop ignoring lines after: <!-- textidote: ignore end -->
  1. Ignore front matter: See Ignore Markdown Front Matter #179

closes #168
closes #179

@daniel-vera-g
Fix(MarkdownCleaner): Be able to ignore comments, lines and front matter
25e34fe 
1. Ignore regular, inline and multiline comments
2. Be able to ignore parts of the text
3. Ignore front matter
@daniel-vera-g
fix: multiline comments allow inline parts
75a80ad 
Allow inline multiline comments, where the beginning or the end can contain regular text
@sylvainhalle sylvainhalle merged commit 9a2006f into sylvainhalle:master Jul 26, 2021
@sylvainhalle
Copy link
Owner

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignore Markdown Front Matter Be able to ignore lines
2 participants
@daniel-vera-g @sylvainhalle