techdebt: remove support for old distros (3.10 targets) #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A workaround was in place for squashfs-tools <4.3 which does not support the `user-xattrs` flag. All our target distros use 4.3 or later, so remove the conditionals to simplify the squashfs unpack logic.
We no longer support EL6 which has been EOL for some time.
In starter we are currently allowing _LINUX_CAPABILITY_VERSION_2, but this was specific to kernel 2.6.25, and deprecated in 2.6.26, which is older than used by any system we target / test on. See also: https://github.com/torvalds/linux/blob/v2.6.26/include/linux/capability.h#L34 https://man7.org/linux/man-pages/man2/capset.2.html Kernels prior to 2.6.25 prefer 32-bit capabilities with version _LINUX_CAPABILITY_VERSION_1. Linux 2.6.25 added 64-bit capability sets, with version _LINUX_CAPABILITY_VERSION_2. There was, however, an API glitch, and Linux 2.6.26 added _LINUX_CAPABILITY_VERSION_3 to fix the problem.
This was referenced May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
techdebt: Remove workaround for squashfs-tools <4.3
A workaround was in place for squashfs-tools <4.3 which does not support the
user-xattrsflag. All our target distros use 4.3 orlater, so remove the conditionals to simplify the squashfs unpack logic.
techdebt: remove pkg/network test conditional for EL6
We no longer support EL6 which has been EOL for some time.
techdebt: drop _LINUX_CAPABILITY_VERSION_2 support
In starter we are currently allowing _LINUX_CAPABILITY_VERSION_2, but this was specific to kernel 2.6.25, and deprecated in 2.6.26, which is older than used by any system we target / test on.
See also:
https://github.com/torvalds/linux/blob/v2.6.26/include/linux/capability.h#L34
https://man7.org/linux/man-pages/man2/capset.2.html
This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make checkand tested this PR locally with amake test, andmake testallif possible (see CONTRIBUTING.md).