-
Notifications
You must be signed in to change notification settings - Fork 104
oci: buildkit TMPDIR fallback #3407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(This is probably an separate issue) It appears that if XDG_RUNTIME_DIR is unset, the singularity-buildkitd unix domain socket is created in /run/singularity-buildkitd/ by default, which would fail in the rootless case (as on a multi-tenant HPC cluster):
Setting XDG_RUNTIME_DIR to a user-writable path (which may be nonexistent before running
I may have had XDG_RUNTIME_DIR set in my environment when reporting #3382. That said, this PR appears to address issue #3382 (including a helpful error when TMPDIR is set to a non-local file system). |
Will tackle as a separate issue. Should be straightforward to follow a similar approache as #3402 |
Detect whether the `~/singularity.d/singularity-buildkit` location can be used for buildkit. Full overlay support is required. If not compatible, try falling back to a temporary directory with a warning that there will be no persistent cache. If TMPDIR is not compatible, give a sensible fatal error. Fixes sylabs#3382
Description of the Pull Request (PR):
Detect whether the
~/singularity.d/singularity-buildkit
location can be used for buildkit. Full overlay support is required.If not compatible, try falling back to a temporary directory with a warning that there will be no persistent cache.
If TMPDIR is not compatible, give a sensible fatal error.
Example behaviour
With an incompatible TMPDIR:
This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make check
and tested this PR locally with amake test
, andmake testall
if possible (see CONTRIBUTING.md).